Add prototype code to download NASA data by j8xixo12 · Pull Request #688 · solvcon/modmesh

j8xixo12 · 2026-03-07T08:14:42Z

This PR is derivatived from #684 and adding a downloader for downloading the nasa problem dataset and untar the data.

yungyuc

Points to address.

Keep only one author in copyright header.
Use full text for BSD license in the copyright header.
Add docstrings to explain how to use this tool from command line.

yungyuc · 2026-03-07T12:49:28Z

modmesh/track/__init__.py

@@ -0,0 +1,13 @@
+# Copyright (c) 2026, Chun-Shih Chang <austin20463@gmail.com>,
+# Chun-Hsu Lai <as2266317@gmail.com>


Keep only one author. @j8xixo12 @ThreeMonth03 , you decide who is listed in the copyright header.

yungyuc · 2026-03-07T12:50:03Z

modmesh/track/__init__.py

@@ -0,0 +1,13 @@
+# Copyright (c) 2026, Chun-Shih Chang <austin20463@gmail.com>,
+# Chun-Hsu Lai <as2266317@gmail.com>
+# BSD 3-Clause License, see COPYING


Use full text for license in the file copyright header.

yungyuc · 2026-03-07T12:51:02Z

modmesh/track/dataset.py

+        Initialize download/load configuration.
+        """
+
+        self.url = "https://techport.nasa.gov/api/file/presignedUrl/380503"


Make URL an argument.

yungyuc · 2026-03-07T12:51:33Z

modmesh/track/__init__.py

+# BSD 3-Clause License, see COPYING
+
+"""
+track: Track nasa flight dataset with Kalman Filter.


Add docstrings to explain how to use this tool from command line.

j8xixo12

@yungyuc This PR is ready for the next review.

j8xixo12 · 2026-03-07T15:32:54Z

modmesh/track/__init__.py

+# OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
+# LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
+# NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE,
+# EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.


@yungyuc I have put the full text of BSD-3 clause license.

j8xixo12 · 2026-03-07T15:33:17Z

modmesh/track/__init__.py

@@ -0,0 +1,38 @@
+# Copyright (c) 2026, Chun-Shih Chang <austin20463@gmail.com>


@ThreeMonth03 I put your name as the author!

j8xixo12 · 2026-03-07T15:35:00Z

modmesh/track/__init__.py

+track: Track NASA flight dataset with Kalman Filter.
+
+How to download the dataset:
+PYTHONPATH=. python3 -m modmesh.track.dataset


I added the dataset download cli example here.

I do not think the leading PYTHONPATH=. should be used. If it is needed, please clarify why.

Use rst format for the code literal block with the notation ::. Write it like:

How to download the dataset:: python3 -m modmesh.track.dataset

j8xixo12 · 2026-03-07T15:40:12Z

modmesh/track/dataset.py

+        "https://techport.nasa.gov/api/file/presignedUrl/380503",
+        "DDL-F1_Dataset-20201013.zip",


To accommodate different file names for different url. I have modified the NasaDataset to take url and file name as arguments.

yungyuc

Improve the docstrings to explain the command-line use.

yungyuc · 2026-03-09T13:59:54Z

modmesh/track/__init__.py

+track: Track NASA flight dataset with Kalman Filter.
+
+How to download the dataset:
+PYTHONPATH=. python3 -m modmesh.track.dataset


I do not think the leading PYTHONPATH=. should be used. If it is needed, please clarify why.

Use rst format for the code literal block with the notation ::. Write it like:

How to download the dataset:: python3 -m modmesh.track.dataset

j8xixo12

@yungyuc this pr is ready for next review.

j8xixo12 · 2026-03-11T15:05:10Z

modmesh/track/__init__.py

+How to download the dataset::
+
+  python3 -m modmesh.track.dataset


@yungyuc I have modified the docstring using rst format, and you are right the leading PYTHONPATH=. is necessary.

Thanks for checking this. It looks good.

yungyuc

LGTM

yungyuc · 2026-03-12T00:54:22Z

modmesh/track/__init__.py

+How to download the dataset::
+
+  python3 -m modmesh.track.dataset


Thanks for checking this. It looks good.

yungyuc · 2026-03-12T00:58:36Z

@j8xixo12 we do not use semantic commit convention. It distracts and suppresses insightful commit logs. I will reword the commits and merge later.

Also tweak the code and text for minor improvements

j8xixo12 force-pushed the download_nasa_data branch from a42c603 to fefe6c8 Compare March 7, 2026 08:19

j8xixo12 mentioned this pull request Mar 7, 2026

Estimate the position and attitude of NASA flight using Kalman Filter #685

Open

4 tasks

yungyuc requested changes Mar 7, 2026

View reviewed changes

yungyuc assigned j8xixo12 and ThreeMonth03 Mar 7, 2026

yungyuc requested a review from ThreeMonth03 March 7, 2026 12:52

yungyuc added the array Multi-dimensional array implementation label Mar 7, 2026

j8xixo12 force-pushed the download_nasa_data branch from 60c4216 to 91b523b Compare March 7, 2026 15:43

j8xixo12 commented Mar 7, 2026

View reviewed changes

yungyuc requested changes Mar 9, 2026

View reviewed changes

j8xixo12 commented Mar 11, 2026

View reviewed changes

yungyuc approved these changes Mar 12, 2026

View reviewed changes

j8xixo12 added 3 commits March 12, 2026 09:01

Add code the download data from NASA for the orbital problem

e291b38

Keep a single author name and add full copyright text

f2ee5ee

Add docstrings for the example to download using the command line

529d4e1

Also tweak the code and text for minor improvements

yungyuc force-pushed the download_nasa_data branch from 04f7226 to 529d4e1 Compare March 12, 2026 01:03

yungyuc merged commit 2458c4b into solvcon:master Mar 12, 2026
14 checks passed

yungyuc changed the title ~~feat: add nasa problem downloader~~ Add prototype code to download NASA data Mar 12, 2026

yungyuc linked an issue Mar 12, 2026 that may be closed by this pull request

Estimate the position and attitude of NASA flight using Kalman Filter #685

Open

4 tasks

		@@ -0,0 +1,13 @@
		# Copyright (c) 2026, Chun-Shih Chang <austin20463@gmail.com>,
		# Chun-Hsu Lai <as2266317@gmail.com>

		@@ -0,0 +1,38 @@
		# Copyright (c) 2026, Chun-Shih Chang <austin20463@gmail.com>

		"https://techport.nasa.gov/api/file/presignedUrl/380503",
		"DDL-F1_Dataset-20201013.zip",

		How to download the dataset::

		python3 -m modmesh.track.dataset

Conversation

j8xixo12 commented Mar 7, 2026

Uh oh!

yungyuc left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

j8xixo12 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yungyuc left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

j8xixo12 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yungyuc left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yungyuc commented Mar 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

yungyuc left a comment •

edited

Loading

yungyuc left a comment •

edited

Loading