Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a crash that occurs if .pck file was in Big-Endian. This PR also adds support for DLCs that have Skins.pck inside them.
Changes
Previous Behavior
Game crashed when Big-Endian aligned DLC was trying to load.
Root Cause
Had to swap between Big and Little Endian alignments.
New Behavior
Now Big- and Little Endian aligned DLCs can load. PS3 Skin DLCs can now load without any modifications done to them (64x32 looking fine, 64x64 are still broken until someone's PR is merged). Other PS3 DLCs might require further changes, as in, texture packs, audio, maps.
Fix Implementation
Added few helper functions to read and swap bytes easily.
AI Use Disclosure
No AI was used.
Related Issues