Added Coming Soon Error to Achievements#1284
Open
Xenovyy wants to merge 3 commits intosmartcmd:mainfrom
Open
Conversation
uncommented the line that plays the press sound effect
Temporarily added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a "Coming Soon" Error box when clicking the Achievements button in the title screen.
Edit: Also added Coming Soon string for the Leaderboards.
Changes
Previous Behavior
Previously, the button would do absolutely nothing.
Root Cause
The Achievements tab was built for console software.
New Behavior
Now displays a small popup with the title "Feature Coming Soon." and description "This feature isn't fully supported at the moment."
Fix Implementation
Added two strings:
IDS_FEATURENOTIMPLEMENTED_TEXT
IDS_FEATURENOTIMPLEMENTED_TITLE
Commented out the old code for the achievements, easily restorable.
Commented out old string for the Leaderboard loading screen, easily restorable.
Media
AI Use Disclosure
No AI was used.
Related Issues