-
Notifications
You must be signed in to change notification settings - Fork 21
Add counter 1/f and common mode subtraction to preprocess #1396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
With this change, get_pca_model returns weight with imaginary part when the given input signal is Q+iU.
|
I guess it would be better to modify |
msilvafe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few requests and questions inline
|
In the following places, here:
and here:
You mention downsampling but that's not implemented here do you just mean demodulated and/or low pass filtered? |
|
Also why do you need these 3 different rotation steps, especially for telescope vs radial Q/U rotation shouldn't it be one or the other not both?
|
These steps operate,
respectively. |
I'm sorry! Exactly, downsample is a mistake for low pass filtering. |
| "low_pass_butter4": { | ||
| "fc": "fknee", | ||
| }, | ||
| "low_pass_sine2": { | ||
| "cutoff": "fknee", | ||
| "width": None | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't add lowpass filters to highpass filter function.
b24c802 to
5bfc4d7
Compare
This PR modifies the scripts to enable fancy counter 1/f filter and common mode subtraction.
The changes for counter 1/f filter:
The filter function 'counter_1_over_f' is modified to accept the array-like input of parameters.
This enables to apply independent 1/f parameters to individual detectors.
The changes for common mode subtraction:
The PCAFilter is modified to have
signalandmodel_signalindependently.This enables to estimate PCA model from the down sampled signal, and then subtract it from the signal.
For the fancy operations, I introduced
get_common_noise_paramsto estimate knee frequency of the common noise.The estimated knee frequency is applied to the down sample frequency of
model_signal.However, this deployment requires many changes in
fft_ops.(As common mode aman doesn't have 'dets' LabelAxis, aman.dets is changed to aman[LabelAxis].)
These changes can be discarded if they are too much.
The following lines are the example of the process pipeline after the demodulation.
I have confirmed the processes run with this config.