Skip to content

chore: Format snippets#345

Open
nielsenko wants to merge 5 commits intoserverpod:mainfrom
nielsenko:chore-format-snippets
Open

chore: Format snippets#345
nielsenko wants to merge 5 commits intoserverpod:mainfrom
nielsenko:chore-format-snippets

Conversation

@nielsenko
Copy link
Collaborator

@nielsenko nielsenko commented Mar 11, 2026

  • Use snip tool to format dart code in markdown and dart doc comments.
  • Some corrections where needed as not all snippets where valid dart code.
  • Also adds check on ci.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 11, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: ff77a38a-1d1d-47f7-bf79-45df60979f3a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nielsenko nielsenko force-pushed the chore-format-snippets branch from 33980e6 to 21faacf Compare March 11, 2026 08:46
@codecov
Copy link

codecov bot commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.19%. Comparing base (b11216b) to head (21faacf).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #345   +/-   ##
=======================================
  Coverage   91.19%   91.19%           
=======================================
  Files          98       98           
  Lines        3849     3849           
  Branches     1964     1964           
=======================================
  Hits         3510     3510           
  Misses        339      339           
Flag Coverage Δ
relic_core 90.90% <ø> (ø)
relic_io 93.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nielsenko nielsenko self-assigned this Mar 11, 2026
@nielsenko nielsenko requested a review from a team March 11, 2026 09:02
@nielsenko nielsenko marked this pull request as ready for review March 11, 2026 09:02
Copy link
Collaborator

@marcelomendoncasoares marcelomendoncasoares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great UX with the snip tool!! Next step for the future is to have it in a pre-commit hook so we ensure to never have conflicts on CI. I have only one question, though, that I think would be nice to preserve on the snippets as they were.

Comment on lines +47 to +50
run: >-
dart format --output=none --set-exit-if-changed . &&
dart pub global activate --source git https://github.com/nielsenko/snip.git &&
snip format . --no-apply
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Is it possible to preserver trailing commas on the formatting? I would say that some of the snippets lost a bit in readability due to not preserving them.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.. 2m

@exaby73 exaby73 changed the title chore: Formart snippets chore: Format snippets Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants