Skip to content

Conversation

@agriyakhetarpal
Copy link
Member

From scientific-python/specs#414; @stefanv suggests that this might be the way to fix it.

cc: @bsipocz @stefanv

@netlify
Copy link

netlify bot commented Dec 12, 2025

Deploy Preview for scientific-python-org ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit fd3a358
🔍 Latest deploy log https://app.netlify.com/projects/scientific-python-org/deploys/693c6c544f18750007527afd
😎 Deploy Preview https://deploy-preview-832--scientific-python-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95
Accessibility: 100
Best Practices: 100
SEO: 100
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@bsipocz
Copy link
Member

bsipocz commented Dec 12, 2025

Could you also fix this in the specs repo, so we will have passing previews in there?

@bsipocz bsipocz merged commit bd0800b into scientific-python:main Dec 12, 2025
5 checks passed
@agriyakhetarpal agriyakhetarpal deleted the yaml2ics-fix branch December 13, 2025 21:09
@agriyakhetarpal
Copy link
Member Author

@bsipocz, the specs repo clones this repo here:

https://github.com/scientific-python/specs/blob/45fa63798045fab620e01fe4886213fa7e215544/Makefile#L11

And it's not fixed to a branch/tag but rather to the main branch. This PR, having been merged, should fix the issue, and we will encounter no further build failures in the specs repo on any subsequent PRs/updates to existing PRs.

This is, of course, if I misunderstood what you meant – please clarify if I did, thanks!

@bsipocz
Copy link
Member

bsipocz commented Dec 13, 2025

Oh, I haven't looked into it just had assumptions, thanks for digging things up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants