-
Notifications
You must be signed in to change notification settings - Fork 131
Add FindByPropertyValue custom queries and add bulkrax to test applications #7320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
dlpierce
wants to merge
9
commits into
main
Choose a base branch
from
add_bulkrax
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes four permutations of query styles, including `find_by_property_value` as a replacement for the one bulkrax currently provides.
Various non-valkyrie code paths are used conditionally if the `Wings` constant is defined. This is not a problem for dassie, but is used there too to stay consistent.
Test Results 13 files ± 0 8 errors 5 suites - 8 2h 1m 55s ⏱️ - 47m 33s For more details on these parsing errors and failures, see this check. Results for commit 66d749a. ± Comparison against base commit b29b5e6. This pull request removes 434 and adds 196 tests. Note that renamed tests count towards both.This pull request skips 16 tests.♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #7119
Summary
Support for bulkrax in Valkyrie w/Fedora applications.
Guidance for testing, such as acceptance criteria or new user interface behaviors:
Detailed Description
In order to better support the widely used bulkrax tool, it has been installed in the test applications (and therefore also in the nurax servers).
It was discovered the
find_by_property_valuecustom query provided by bulkrax was written assuming postgres would be the metadata adapter in use. This has been replaced in this PR by a set of custom queries instead utilizing solr.Changes proposed in this pull request:
@samvera/hyrax-code-reviewers