feat(ini) support different settings for php.ini#210
Open
scambra wants to merge 1 commit intosaltstack-formulas:masterfrom
Open
feat(ini) support different settings for php.ini#210scambra wants to merge 1 commit intosaltstack-formulas:masterfrom
scambra wants to merge 1 commit intosaltstack-formulas:masterfrom
Conversation
Contributor
|
@scambra Sorry for the delay, we need to get some eyes on this from those who use the formula. How about @grandmotivator? Could you try this out? |
When php:version is a list, a dict with settings for different
versions can be added under ini key of cli and fpm:config keys
php:
fpm:
config:
ini:
settings:
# global settings
'5.6':
# settings for 5.6 only
cli:
ini:
settings:
# global settings
'5.6':
# settings for 5.6 only
Contributor
|
@sticky-note Would you be able to review this as well? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When php:version is a list, a dict with settings for different
versions can be added under ini key of cli and fpm:config keys
Related to #138, grandmotivator comment