Open
Conversation
fix merge like other ini files
Contributor
|
Thanks for this, @ze42. A couple of things to consider: This repo now uses Only the commit title would need to be modified, the body can stay as-is. So a suggestion: -apache2/ini: fix config merge
+fix(apache2/ini): fix config mergeThe second thing is that this will probably have to be merged after #183. We've caused the author of that PR far too much hassle every time we merge a PR, so this PR will have a simple adjustment afterwards in comparison. If you're a user of this formula, it would be great if you could test #183 at your end so that we can get on with merging it. |
Contributor
Contributor
|
Hi there! Any news? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix merge like other ini files