fix(repositories): force aptkey if signed-by and allow aptkey#79
Merged
javierbertoli merged 1 commit intosaltstack-formulas:masterfrom Apr 14, 2025
Merged
Conversation
javierbertoli
requested changes
Apr 11, 2025
Member
javierbertoli
left a comment
javierbertoli
left a comment
There was a problem hiding this comment.
It LGTM, just a simple change, for consistency with other vars
didiermfb
force-pushed
the
fix/repository_aptkey_signedby
branch
from
6120921 to
3e11c59
Compare
Contributor
Author
|
Var renamed. |
Contributor
Author
|
The review is completed. Can someone merge this PR ? (I would like to rebase #80 because there will be conflicts) |
|
🎉 This PR is included in version 0.11.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]Changes related to the build system[chore]Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]Changes to the continuous integration configuration[feat]A new feature[fix]A bug fix[perf]A code change that improves performance[refactor]A code change that neither fixes a bug nor adds a feature[revert]A change used to revert a previous commit[style]Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]Documentation changes[test]Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE?No.
Related issues and/or pull requests
#76
Describe the changes you're proposing
If key_url is defined and aptkey is not defined, force aptkey to false when signed-by is present in opts.
Use aptkey if defined in any case.
Allow to define keyring directory and clean this directory (cleaning is set to false by default)
Pillar / config required to test the proposed changes
Added to pillar.example
Debug log showing how the proposed changes work
Documentation checklist
README(e.g.Available states).pillar.example.Testing checklist
state_top).Additional context
keyring directory is managed automatically by salt not by this formula (didn't see any possible configuration in pkgrepo to change this) The directory is just set to be able to clean this directory.
It should be better to define all the signed-by in the same directory (except for keyrings pushed by the keyring_package)
Closing previous PR to split modifications and base this PR on specific branch