Move rwviewer into rwgame with imgui by danhedron · Pull Request #719 · rwengine/openrw

danhedron · 2019-05-27T21:32:12Z

This removes a lot of stuff that's needed just for Qt and simplifies the code.

A few things left to match functionality with rwviewer

Free-cam map viewer
Make it possible to remove viewed objects

rwgame/RWGame.cpp

ghost · 2019-05-27T21:53:04Z

rwgame/RWViewer.cpp

+        std::transform(filename.begin(), filename.end(), filename.begin(),
+                       ::tolower);
+        if (!filename.compare("text")) {
+            textPath = p;


nit: std::move?

ghost · 2019-05-27T21:53:51Z

rwgame/RWViewer.cpp

+        throw std::runtime_error("text directory not found in gamedata path");
+    }
+    std::vector<std::string> names;
+    for (const rwfs::path& p : rwfs::directory_iterator(textPath)) {


nit: allocate memory for all at once?

ghost · 2019-05-27T21:53:58Z

rwgame/RWViewer.cpp

+        auto langName = p.filename().string();
+        std::transform(langName.begin(), langName.end(), langName.begin(),
+                       ::tolower);
+        names.push_back(langName);


nit: std::move?

rwgame/RWViewer.hpp

rwgame/RWGame.cpp

rwgame/RWViewer.cpp

ghost · 2019-05-27T22:08:42Z

rwgame/RWViewer.cpp

+                if (ImGui::Selectable(it->second.second.c_str(), false,
+                                      ImGuiSelectableFlags_AllowDoubleClick)) {
+                    if (ImGui::IsMouseDoubleClicked(0)) {
+                        strncpy(previewStr_, it->second.second.c_str(), 512);


std::copy_n

codecov · 2019-05-27T23:32:48Z

Codecov Report

Merging #719 into master will increase coverage by 0.59%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #719      +/-   ##
==========================================
+ Coverage   18.12%   18.72%   +0.59%     
==========================================
  Files         252      229      -23     
  Lines       22938    22211     -727     
  Branches     5769     5795      +26     
==========================================
  Hits         4158     4158              
+ Misses      17659    16935     -724     
+ Partials     1121     1118       -3

Impacted Files	Coverage Δ
rwgame/RWGame.hpp	`0% <ø> (ø)`	⬆️
rwgame/main.cpp	`0% <0%> (ø)`	⬆️
rwgame/RWConfig.inc	`46.66% <0%> (-3.34%)`	⬇️
rwgame/viewer/RWViewer.hpp	`0% <0%> (ø)`
rwgame/viewer/RWViewerWindows.cpp	`0% <0%> (ø)`
rwgame/RWImGui.cpp	`0% <0%> (ø)`	⬆️
rwgame/RWGame.cpp	`0% <0%> (ø)`	⬆️
rwgame/viewer/RWViewerWindows.hpp	`0% <0%> (ø)`
rwgame/viewer/RWViewer.cpp	`0% <0%> (ø)`
rwengine/src/objects/CharacterObject.cpp	`13.25% <0%> (ø)`	⬆️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51b7264...69afb86. Read the comment docs.

Access with `--viewer`, this replaces the Qt based tool