Skip to content

Conversation

@usamoi
Copy link
Contributor

@usamoi usamoi commented Jan 10, 2026

Usage of them is accepted by clang without fullfp16 (https://godbolt.org/z/dhffa4YT9). It seems that they are missing in #1978.

cc @adamgemmell, in case I misunderstood

@rustbot
Copy link
Collaborator

rustbot commented Jan 10, 2026

r? @Amanieu

rustbot has assigned @Amanieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@adamgemmell
Copy link
Contributor

Looks good to me, thank you!

assert_instr(nop)
)]
#[target_feature(enable = "neon,fp16")]
#[cfg_attr(target_arch = "arm", target_feature(enable = "fp16"))]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe the fp16 target feature is required on 32-bit either.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what was done in #1978, for stores and loads.
@adamgemmell, do you have ideas?

Copy link
Contributor

@adamgemmell adamgemmell Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vreinterprets are NOPs, so there's no issues with the instruction not being available on 32 bit platforms. If it builds and the tests pass then it's fine to remove for both sets of targets

@usamoi
Copy link
Contributor Author

usamoi commented Jan 28, 2026

fp16 is removed on arm now.

The second commit is for passing CI. rust-lang/rust#151529

@folkertdev folkertdev added this pull request to the merge queue Jan 28, 2026
@folkertdev
Copy link
Contributor

For context: this includes a fix for miri failing to build std, see https://rust-lang.zulipchat.com/#narrow/channel/269128-miri/topic/Miri.20test-libstd.20Failure.20.282026-01.29/near/570520551

Merged via the queue into rust-lang:main with commit 9040e2f Jan 28, 2026
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants