Conversation
smrutherford
requested changes
Jun 7, 2018
Contributor
smrutherford
left a comment
smrutherford
left a comment
There was a problem hiding this comment.
Overall, looks good! Good job on testing coverage. My only reservation is that you update your test names to be consistent. See my specific comment on one of your test names.
| 'no-console': 'off', | ||
| 'no-underscore-dangle': ['error', { allow: ['_id'] }], | ||
| 'no-plusplus': 'off' | ||
| 'no-plusplus': 'off', |
Contributor
There was a problem hiding this comment.
You might want to keep this rule so that everyone's code is consistent.
| @@ -23,6 +24,7 @@ | |||
| "eslint-config-hackreactor": "git://github.com/reactorcore/eslint-config-hackreactor", | |||
Contributor
There was a problem hiding this comment.
I think you can uninstall HR's linter since we're using the airbnb linter. Also, don't forget to update your STYLE-GUIDE.md to refer to the airbnb linter.
| const hostelRecord = await Hostel.findOne({}); | ||
| expect(hostelRecord._id).toBeTruthy(); | ||
| }); | ||
| test('each hostel record should have a name field', async () => { |
Contributor
There was a problem hiding this comment.
I think it's best to remain consistent with test names. For example, update this to read 'should have a name field for each hostel'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.