Merged
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Implement MCP server tools (Tasks 5-8): - ShowOrganizationTool: view organization details by ID - Client tools: ListClientsTool, ShowClientTool, CreateClientTool, UpdateClientTool, DeleteClientTool (soft delete via discard) - Project tools: ListProjectsTool, ShowProjectTool, CreateProjectTool, UpdateProjectTool, DeleteProjectTool (soft delete via discard) - Task tools: ListTasksTool, ShowTaskTool (read-only) All tools follow ActionPolicy authorization patterns matching the existing API controllers, use authorized_scope for data isolation, and include comprehensive test coverage. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Non-admin users were able to list projects via MCP tool when the API controller would return 403 Forbidden. Now matches the API behavior. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Implement the remaining MCP tools: - TimeReg tools: list (with pagination), show, create, update, delete - ToggleTimerTool: start/stop timer on time registrations - User tools: list, show, get_current_user (with org info) - RegenerateApiTokenTool: regenerate the current user's API token - GetReportsTool: aggregated time reports with project/user breakdowns All tools follow existing authorization patterns using ActionPolicy scopes (`:own` for time_regs, full scope for reports). Includes comprehensive tests covering happy paths, auth errors, and access control boundaries. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Extract format_time_reg to ApplicationTool base class (was duplicated in 5 files) - Add authorize! calls to ListClientsTool and ListTasksTool for consistency with API controllers - Fix ListProjectsTool authorize! to not pass unnecessary record arg - Remove unused application_resource.rb Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
MCP clients should not be able to reset or supply API tokens. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
kaospr
commented
Mar 5, 2026
Collaborator
Author
kaospr
left a comment
kaospr
left a comment
There was a problem hiding this comment.
Lets try this out! 😁
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.