Upgrade standard-rails #6684
Merged
Upgrade standard-rails #6684
+48
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RailsPluck cop is disabled by default because it can lead to some problems when associations are not loaded inside of iterations. However, all the problems being fixed here are from tests and since they are passing, I am assuming there are no issues following this cop. https://docs.rubocop.org/rubocop-rails/cops_rails.html#railspluck
github-actions
bot
added
dependencies
stefannibrasil
requested review from
FireLemons,
compwron and
elasticspoon
as code owners
Collaborator
|
🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #6683
Related to #6677
The RailsPluck cop is disabled by default because it can lead to some problems when associations are not loaded inside of iterations. However, all the problems being fixed here are from tests and since they are passing, I am assuming there are no issues following this cop. Let me know if you'd prefer to disable this cop instead.
https://docs.rubocop.org/rubocop-rails/cops_rails.html#railspluck