Skip to content

Conversation

@sinsoku
Copy link
Contributor

@sinsoku sinsoku commented Dec 14, 2025

This commit adds support for nested destructuring assignments like
a, (b, c) = [1, [2, 3]], which previously caused a
"RuntimeError: not supported yet: multi_target_node" error.

Changes:

  • Add MultiTargetNode class to handle nested destructuring targets
  • Extend create_target_node to support :multi_target_node type
  • Add nil guards for rights parameter in MAsgnBox and Type::Array#splat_assign
  • Add comprehensive test cases for nested destructuring patterns

🤖 Generated with Claude Code

Co-Authored-By: Claude [email protected]

This commit adds support for nested destructuring assignments like
`a, (b, c) = [1, [2, 3]]`, which previously caused a
"RuntimeError: not supported yet: multi_target_node" error.

Changes:
- Add MultiTargetNode class to handle nested destructuring targets
- Extend create_target_node to support :multi_target_node type
- Add nil guards for `rights` parameter in MAsgnBox and Type::Array#splat_assign
- Add comprehensive test cases for nested destructuring patterns

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
Copy link
Member

@mame mame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect!

@mame mame merged commit 1a25a72 into ruby:master Dec 23, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants