Suppress error highlight for some incomplete code#1173
Merged
tompng merged 2 commits intoruby:masterfrom Feb 16, 2026
Merged
Conversation
It is better to not render `class` with RED-REVERSE color. Filter specific errors if error location is at the last non-newline non-comment token position.
st0012
approved these changes
Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is better to not render
classwith RED-REVERSE color. Filter specific errors if error location is at the last non-newline non-comment token position.classwas rendered RED-REVERSE, will be rendered GREENclass;will be rendered RED-REVESE as beforeDetail
Many errors at the end should be highlighted
def f.@invalid_method_name1@a:123tap do end endOnly a few error types at the end should be filtered out
classclass a(followed by::Ais valid)a,b(followed by=cis valid)[*f(**f(&def f ==beginSome patterns aren't possible to handle with the approach in this pull request
def $a(followed by.fis valid)def $a.$a(invalid, same error will be raised)*,(followed bya=bis valid, but error location is not at the end)