JointTrajectory: Don't use shortest_angular_distance for linear joints#623
Open
bmagyar wants to merge 1 commit intonoetic-develfrom
Open
JointTrajectory: Don't use shortest_angular_distance for linear joints#623bmagyar wants to merge 1 commit intonoetic-develfrom
bmagyar wants to merge 1 commit intonoetic-develfrom
Conversation
Member
Author
|
@steinmn could you please nod in agreement? ;) |
steinmn
suggested changes
Nov 13, 2023
steinmn
left a comment
steinmn
left a comment
There was a problem hiding this comment.
On second thought, something doesn't look quite right here
Comment on lines
+786
to
797
| if (is_linear_[joint_index]) | ||
| { | ||
| state_joint_error_.position[0] = desired_joint_state_.position[0] - current_state_.position[joint_index]; | ||
| } | ||
| else | ||
| { | ||
| state_joint_error_.position[0] = angles::shortest_angular_distance(current_state_.position[joint_index],desired_joint_state_.position[0]); | ||
| } | ||
| state_joint_error_.velocity[0] = desired_joint_state_.velocity[0] - current_state_.velocity[joint_index]; | ||
| state_joint_error_.acceleration[0] = 0.0; | ||
|
|
||
| state_error_.position[joint_index] = angles::shortest_angular_distance(current_state_.position[joint_index],desired_joint_state_.position[0]); |
There was a problem hiding this comment.
Suggested change
| if (is_linear_[joint_index]) | |
| { | |
| state_joint_error_.position[0] = desired_joint_state_.position[0] - current_state_.position[joint_index]; | |
| } | |
| else | |
| { | |
| state_joint_error_.position[0] = angles::shortest_angular_distance(current_state_.position[joint_index],desired_joint_state_.position[0]); | |
| } | |
| state_joint_error_.velocity[0] = desired_joint_state_.velocity[0] - current_state_.velocity[joint_index]; | |
| state_joint_error_.acceleration[0] = 0.0; | |
| state_error_.position[joint_index] = angles::shortest_angular_distance(current_state_.position[joint_index],desired_joint_state_.position[0]); | |
| if (is_linear_[joint_index]) | |
| { | |
| state_error_.position[joint_index] = desired_joint_state_.position[0] - current_state_.position[joint_index]; | |
| } | |
| else | |
| { | |
| state_error_.position[joint_index] = angles::shortest_angular_distance(current_state_.position[joint_index],desired_joint_state_.position[0]); | |
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #432
Port #591 to Noetic