Open
Conversation
…-stop-recursion Stop logging recursion.
Contributor
Author
|
@markrwilliams here's what ends up looping: |
Contributor
|
#172 needs to get addressed and this appears to go towards that, but I'm going to bump this to the next release because getting into the weeds of twisted is not what I want to have hold up a bunch of other changes |
Contributor
|
Fixes #163 |
…agent then things will be broken, fix that
Contributor
Author
|
This is a tough one dude! Very curious to see how you end up preventing that infinite loop. |
Contributor
|
With the current code, as far as I can tell, there are no infinite loops in the case of an SSL error. If you get rid of the add/remove observer stuff then you do get some looping so it appears that is part of the solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will:
Testing:
Status:
Attempting to reproduce some edge casesUseinlineCallbacksto reduce lines of codeerr.typeinlog_handleris a specific Twisted Exception or some subclass of one and don't send it back toreport_exc_info. The nicer alternative would be to somehow tag an error as coming from Rollbar but I'm not quite there yet.