Fix WaitUntilCommand for match time counting down#247
Merged
auscompgeek merged 2 commits intorobotpy:mainfrom Feb 27, 2026
Merged
Fix WaitUntilCommand for match time counting down#247auscompgeek merged 2 commits intorobotpy:mainfrom
auscompgeek merged 2 commits intorobotpy:mainfrom
Conversation
Based on wpilibsuite/allwpilib#8632 Fixes issue reported in wpilibsuite/allwpilib#8631 Documents that it will return immediately if FMS isn't attached or DS isn't in practice mode. Related to change in DS match time behavior that was documented in wpilibsuite/allwpilib#8606
auscompgeek
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on wpilibsuite/allwpilib#8632
Fixes issue reported in wpilibsuite/allwpilib#8631
Documents that it will return immediately if FMS isn't attached or DS isn't in practice mode.
Related to change in DS match time behavior that was documented in wpilibsuite/allwpilib#8606