Skip to content

Conversation

@imykhno
Copy link
Contributor

@imykhno imykhno commented Jan 29, 2026

Hey, I just made a Pull Request!

Fix for RHDHBUGS-2554

Fix.RHDHBUGS-2554.mov

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

@rhdh-gh-app
Copy link

rhdh-gh-app bot commented Jan 29, 2026

Changed Packages

Package Name Package Path Changeset Bump Current Version
app workspaces/scorecard/packages/app none v0.0.0
@red-hat-developer-hub/backstage-plugin-scorecard-backend workspaces/scorecard/plugins/scorecard-backend patch v2.3.3
@red-hat-developer-hub/backstage-plugin-scorecard-common workspaces/scorecard/plugins/scorecard-common patch v2.3.3
@red-hat-developer-hub/backstage-plugin-scorecard workspaces/scorecard/plugins/scorecard patch v2.3.3

@imykhno imykhno force-pushed the fix-aggregated-scorecard-widgets branch 2 times, most recently from 4add008 to 6d2a960 Compare January 29, 2026 12:18
…ue or metric fetching fails

Signed-off-by: Ihor Mykhno <[email protected]>
@imykhno imykhno force-pushed the fix-aggregated-scorecard-widgets branch from 6d2a960 to 724cfd6 Compare January 29, 2026 12:23
Copy link
Member

@dzemanov dzemanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @imykhno, looks great.
I have verified permissions error works correctly.
I have verified aggregation with 0 entities / no metric data available:

Image Image

User entity not found doesn't work correctly:

Image

Can we make the text more responsive to fix this when switching languages?

Image

@ShiranHi
Copy link

ShiranHi commented Feb 1, 2026

Thank you @imykhno for this improvement! I have two questions:

  1. Can we verify that all message tooltips are using the same tooltip style?
  2. When a card is in an error state, can we expand the hover target to encompass the entire donut chart area rather than just the thin data lines? It will make the error tooltip significantly easier for users to trigger.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 2, 2026

@imykhno
Copy link
Contributor Author

imykhno commented Feb 2, 2026

Following the previous review, I have implemented logic to display empty cards when the User entity not found error occurs. Additionally, the text on aggregated cards now displays in full when switching languages.

Copy link
Member

@Eswaraiahsapram Eswaraiahsapram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @imykhno. I tested this locally and everything looks good to me.

Image Image Image

Copy link
Member

@dzemanov dzemanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @imykhno.
I have confirmed that user not found error works correctly:
Image
Rechecked error message is displayed in full when switching languages.
Image

We will create a new issue to address #2201 (comment), cc @Eswaraiahsapram.

@dzemanov dzemanov merged commit 4a3369f into redhat-developer:main Feb 2, 2026
9 checks passed
@imykhno imykhno deleted the fix-aggregated-scorecard-widgets branch February 2, 2026 16:32
@imykhno imykhno restored the fix-aggregated-scorecard-widgets branch February 2, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants