-
Notifications
You must be signed in to change notification settings - Fork 90
Scorecard: Fix homepage aggregated scorecard widgets #2201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scorecard: Fix homepage aggregated scorecard widgets #2201
Conversation
…se structure Signed-off-by: Ihor Mykhno <[email protected]>
Changed Packages
|
4add008 to
6d2a960
Compare
…ue or metric fetching fails Signed-off-by: Ihor Mykhno <[email protected]>
6d2a960 to
724cfd6
Compare
Signed-off-by: Ihor Mykhno <[email protected]>
…n failed cards Signed-off-by: Ihor Mykhno <[email protected]>
dzemanov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @imykhno, looks great.
I have verified permissions error works correctly.
I have verified aggregation with 0 entities / no metric data available:
User entity not found doesn't work correctly:
Can we make the text more responsive to fix this when switching languages?
|
Thank you @imykhno for this improvement! I have two questions:
|
Signed-off-by: Ihor Mykhno <[email protected]>
|
|
Following the previous review, I have implemented logic to display empty cards when the |
Eswaraiahsapram
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dzemanov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @imykhno.
I have confirmed that user not found error works correctly:

Rechecked error message is displayed in full when switching languages.

We will create a new issue to address #2201 (comment), cc @Eswaraiahsapram.






Hey, I just made a Pull Request!
Fix for RHDHBUGS-2554
Fix.RHDHBUGS-2554.mov
✔️ Checklist