Skip to content

Conversation

@LagradOst
Copy link
Contributor

After some discussion with @Luna712 I decided to fix some minor issues with the old code.

  1. Now subtitles are deleted properly using the correct SafeFile api
  2. Now delete sections on episodes + movies act way more consistent as the state of "isSelectingItemsRightNow" is now coupled with the type (eg, null = not in selection, empty = no items selected, {a,b,c} = selected a, b and c). I also cleaned up the code around that part too.
  3. Fixed a minor issue with the delete dialog to prevent "delete null?" by reordering the when stmt.

Yall are free to test it out, but I will probs merge it soon.

Copy link
Contributor

@Luna712 Luna712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes all the issues I previously mentioned, but I also noticed another issue with this (though preexisting maybe even on stable) if you select something the multi delete button bytes don't update when total bytes for a certain item change, until you leave the downloads fragment and return to it. I can look into that one though later if you want.

@LagradOst
Copy link
Contributor Author

This fixes all the issues I previously mentioned, but I also noticed another issue with this (though preexisting maybe even on stable) if you select something the multi delete button bytes don't update when total bytes for a certain item change, until you leave the downloads fragment and return to it. I can look into that one though later if you want.

This has always been the case as the actual byte count on each item is rerendered by hooking private state, that is to say the downloadviewmodel does not recalculate byte count at all. This is also not a bug/feature this pull request seeks out to fix.

Moreover, I also do not want anyone to touch that before the download pr #2037 is done, as that modifies that part of the business logic quite a bit.

@LagradOst LagradOst merged commit a46b0ac into master Dec 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants