add singleton image loader, remove unused libs, increase disk & decrease memory cache #1396
Conversation
| //.placeholder(R.drawable.logo) | ||
| //.error(R.drawable.logo) | ||
| .allowHardware(true) | ||
| .allowHardware(false) // takes a toll on battery (only allow if app is like instagram or photos) |
There was a problem hiding this comment.
Is this really the case? I thought hardware bitmaps enabled the hardware to save energy by "offloading the work to dedicated co-processors". Can you link where you got this information or explain more in detail.
There was a problem hiding this comment.
the theory is hw decoding works well only in devices that are recent maybe like sdk int > 28, (point where snapdragon 636 arrived and mediatek started to get a lot better with g85, g90T) and it is only needed to render large bitmaps.
actually we are fucked instacart released coil 3 in which we dont need our own singleton instead we should inherit their factory in application class
inshort alternatively we can set sdk int > 28 instead of false or true if you think it will be better
IndusAryan
changed the title
IndusAryan
changed the title
fire-light42
left a comment
fire-light42
left a comment
There was a problem hiding this comment.
This does not work on image resources, like the source profiles.
|
fixed load bitmap from drawable, and for the hardware thing, we got software render error, because coil themselves have to solve that bitmap render issue on unsupported device |
|
@fire-light42 should we use okhttp client from requests helper here instead of building? |
Yes |
|
i tried to add it, the base client is very confusing, do we set there for each network request, i hope this works same, app is working fine for me |
fire-light42
left a comment
fire-light42
left a comment
There was a problem hiding this comment.
I do not see any obvious issues, so I will merge this after testing 👍
2 participants
annotation processors are now needed if we shift to room sqlite or DI, kapt & ksp were for glide so as transformation lib