Skip to content

Conversation

@maximilianfalco
Copy link
Contributor

PR App Fix CX-2829 Fix CX-2834

🧰 Changes

This PR is an extension of #1279 and does some things, which involves:

  • Integrated the normalizer into magic blocks. Adding the transformer in the local magic block contentParser.
  • Expanded the normalizer to be able to look into multiple AST nodes and not just one "text" node. This happens when there is things like links or nodes within the malformed syntax (eg ** [link](url) **)
  • Expanded the normalizer to also be able to normalizer and accept intraword syntaxes (eg fail_back_, we want to italicize the "back")

🧬 QA & Testing

Look into the attached tickets and simply copy and paste the page contents, the bold and italics should now be exactly as what the editor shows and is the intended behaviour

we need this because in some cases there is a link node (or smth like an inline code) within the ** markers. and this causes remark-parse to "split" the AST so we have to expand the search into nearby nodes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants