Fix response parsing in shaded builds and modernize test environment (#41, #333)#346
Open
maheshshinde9100 wants to merge 2 commits intorazorpay:masterfrom
Open
Fix response parsing in shaded builds and modernize test environment (#41, #333)#346maheshshinde9100 wants to merge 2 commits intorazorpay:masterfrom
maheshshinde9100 wants to merge 2 commits intorazorpay:masterfrom
Conversation
to throw a clear RazorpayException if an entity class cannot be found, rather than failing with a NullPointerException
- Resolve response parsing errors in shaded/re-packaged environments (razorpay#333) - Update Mockito and Jacoco for modern JDK compatibility - Fix deprecated Mockito matchers in BaseTest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: Users reported ClassCastExceptions (Issue #41 and #333) when the SDK was re-packaged or "shaded" into a different namespace. This happened because ApiClient.java had a hardcoded "com.razorpay." string, causing reflection to fail when looking up entity classes in different packages. Additionally, the test suite failed on modern Java versions (JDK 17+) due to legacy Mockito configurations.
Changes:
Impact:
Verification:
mvn clean compile.mvn teston Java 21.