Refactor ApiClient for better readability and performance#345
Open
GauravGavhane18 wants to merge 1 commit intorazorpay:masterfrom
Open
Refactor ApiClient for better readability and performance#345GauravGavhane18 wants to merge 1 commit intorazorpay:masterfrom
GauravGavhane18 wants to merge 1 commit intorazorpay:masterfrom
Conversation
Refactor ApiClient to use static final constants and improve response handling.
|
While refreshing the oauth access token, if refresh token is already revoked, and if we do Here we don't have But can we also include |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored ApiClient to use static final constants for configuration values like API_BASE_URL, connection timeout, and read timeout.
Improved response handling to avoid NullPointerException by adding proper null checks and handling both success and error responses.
Ensured exceptions are caught and returned as readable messages instead of crashing the application.
This change addresses the previous null pointer issue in ApiClient.