Skip to content

Conversation

@rohanchkrabrty
Copy link
Contributor

Description

This PR fixes bugs in Docs

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor (no functional changes, no bug fixes just code improvements)
  • Chore (changes to the build process or auxiliary tools and libraries such as documentation generation)
  • Style (changes that do not affect the meaning of the code (white-space, formatting, etc))
  • Test (adding missing tests or correcting existing tests)
  • Improvement (Improvements to existing code)
  • Other (please specify)

How Has This Been Tested?

Manual

@vercel
Copy link

vercel bot commented Dec 22, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
apsara Ready Ready Preview, Comment Jan 7, 2026 7:29am

@ravisuhag
Copy link
Member

@rohanchkrabrty why do we need hardcode navbar background ? Wouldn't this give wrong impression of default style of component?

@rohanchkrabrty
Copy link
Contributor Author

@rohanchkrabrty why do we need hardcode navbar background ? Wouldn't this give wrong impression of default style of component?

@ravisuhag This is specific to the docs navbar, not the main navbar component. The transparent effect requires the color to be hardcoded instead of variables

@rohanchkrabrty rohanchkrabrty requested review from paanSinghCoder and rsbh and removed request for paanSinghCoder January 5, 2026 17:04
@rohanchkrabrty rohanchkrabrty changed the title fix: docs ui improvements fix: docs ui improvements and component improvements Jan 6, 2026
@paanSinghCoder
Copy link
Contributor

paanSinghCoder commented Jan 6, 2026

Screenshot 2026-01-06 at 11 55 34 AM

@p4suhag @rohanchkrabrty I think we should add some vertical gap between the hover in docs sidebar.

@paanSinghCoder
Copy link
Contributor

Screenshot 2026-01-06 at 11 59 50 AM

@rohanchkrabrty The size input takes n values instead of just 1-6. A dropdown would make more sense here I think.

@rohanchkrabrty rohanchkrabrty merged commit 4e87a62 into main Jan 8, 2026
4 checks passed
@rohanchkrabrty rohanchkrabrty deleted the fix-docs-ui branch January 8, 2026 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants