media: i2c: imx477: Fix uninitialized bug when restarting camera #7191
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In imx477_start_streaming, when restarting before the auto-suspend timeout (5s) so that the common register config write was skipped, "ret" was used uninitialized, leading to intermittent failure. (Since return values are fully checked after the common write, there is anyway no need to propagate ret to mode-specific write.) Signed-off-by: Nick Hollinghurst <[email protected]>
6by9
approved these changes
Jan 8, 2026
Contributor
|
Should this not be back-ported to 6.12? |
Contributor
Author
|
Yes - I will do that. (Does it need a new PR, or any special note in the commit that it's a duplicate?) |
Contributor
|
I'll cherry-pick it. This is a patch that will be carried forward by us, probably squashed, at least until it gets merged upstream. The only time we appreciate special comments in the commit message is when it is a backport of an upstream commit, and therefore something with a finite shelf life. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Jan 9, 2026
kernel: media: imx335: Support 2x2 binning mode (and misc fixes) See: raspberrypi/linux#7168 kernel: media: i2c: imx477: Fix uninitialized bug when restarting camera See: raspberrypi/linux#7191
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Jan 9, 2026
kernel: media: imx335: Support 2x2 binning mode (and misc fixes) See: raspberrypi/linux#7168 kernel: media: i2c: imx477: Fix uninitialized bug when restarting camera See: raspberrypi/linux#7191
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In imx477_start_streaming, when restarting before the auto-suspend timeout (5s) so that the common register config write was skipped, "ret" was used uninitialized, leading to intermittent failure.
(Since return values are fully checked after the common write, there is anyway no need to propagate ret to mode-specific write.)