fix: lock CI to macOS 14 #1278
fix: lock CI to macOS 14 #1278
Conversation
full context: quickjs-ng#1172 (comment)
There was a problem hiding this comment.
Pull request overview
This PR locks the macOS runner version to macOS 14 in the release workflow to address a specific issue (referenced in GitHub issue #1172). The change replaces macos-latest with macos-14 to ensure consistent behavior in release builds.
- Pins the macOS runner to a specific version (14) instead of using the floating
latesttag
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| macos: | ||
| runs-on: macos-latest | ||
| runs-on: macos-14 |
There was a problem hiding this comment.
This change locks the macOS runner to version 14, but the ci.yml workflow still uses macos-latest in multiple places (lines 500, 532, 557, 666, 673, 695, 704, 707, 720, 723, 727, 739). If the issue referenced in the PR affects macOS runners, consider whether ci.yml should also be updated for consistency to avoid similar issues in CI runs.
|
Is this so the release binary can run on older versions of macos? |
Mainly from I tested Xcode/Apple Clang compiler in macOS 15 (Sequoia) generates less optimized code for floating-point operations, see chart here |
|
@saghul your thoughts? Not a macos user myself so I can't check what @gengjiawen wrote. |
|
@gengjiawen have you tried a different Xcode version? |
I found this by directly download binary in the release page. I only have latest xcode on my mac. |
|
If you are so inclined, https://github.com/XcodesOrg/xcodes allows you to run multiple versions side by side. |
3 participants
full context: #1172 (comment)