Fix unsafe max context

[I8dNLo]

No description provided.

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request introduces changes to the preprocessor utilities. The modifications involve adding the sys and warnings modules and updating the tokenizer loading function. Instead of directly setting the truncation length to the provided context maximum, the function now calculates a max_safe_length as the minimum between the provided max_context and the system's maximum integer size. A warning is generated if the given max_context exceeds the system limit, and the truncation length is set to the safe computed value. No changes were made to the declarations of exported or public entities.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between aa0c475 and 779e9f9.

📒 Files selected for processing (1)

• fastembed/common/preprocessor_utils.py (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (16)

• GitHub Check: Python 3.13.x on windows-latest test
• GitHub Check: Python 3.13.x on macos-latest test
• GitHub Check: Python 3.13.x on ubuntu-latest test
• GitHub Check: Python 3.12.x on windows-latest test
• GitHub Check: Python 3.12.x on macos-latest test
• GitHub Check: Python 3.12.x on ubuntu-latest test
• GitHub Check: Python 3.11.x on windows-latest test
• GitHub Check: Python 3.11.x on macos-latest test
• GitHub Check: Python 3.11.x on ubuntu-latest test
• GitHub Check: Python 3.10.x on windows-latest test
• GitHub Check: Python 3.10.x on macos-latest test
• GitHub Check: Python 3.10.x on ubuntu-latest test
• GitHub Check: Python 3.9.x on windows-latest test
• GitHub Check: Python 3.9.x on macos-latest test
• GitHub Check: Python 3.9.x on ubuntu-latest test
• GitHub Check: Python 3.13 test

🔇 Additional comments (2)

fastembed/common/preprocessor_utils.py (2)

4-5: Adding necessary imports for system limits and warnings.

These imports are essential for implementing the safety check against integer overflow in the tokenizer configuration.

---

54-61: Good fix to prevent potential integer overflow issues.

The implementation correctly:

1. Calculates a safe maximum length by comparing the requested context length with the system's maximum integer size
2. Issues an appropriate warning when the requested context length exceeds system limits
3. Uses the safe value for tokenizer truncation

This prevents potential crashes or unexpected behavior when users specify extremely large context windows.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[joein]

I think that this fix can be merged only as a last resort

Sometimes the information on how many tokens a model can work with is implicit or put into config.json, rather than tokenizer_config.json

E.g. model_max_length might be in config.json, or a model can have max_position_embeddings, which is limiting the amount of embeddings a model can compute

I would suggest looking in this direction first