Update pkg_helpers.bash for PyTorch 1.13 release#1924
Update pkg_helpers.bash for PyTorch 1.13 release#1924abhinavarora wants to merge 1 commit intopytorch:release/0.14from
Conversation
mthrok
left a comment
There was a problem hiding this comment.
Why is this necessary?
The current proposed change is touching the code path for nightly build. So I don't think this is correct.
Has something about the release process changed that require change in the bash script?
Hey @mthrok I was just following the step 5 from this wiki. Please let me know if this is stale? |
|
Can you rebase on #1923 and see if it makes difference? I believe it doesn’t make a difference but let’s see. |
|
In the previous release, this change was made as a patch. But I believe that the correct fix is to make Arm Mac build job aware of PYTORCH_VERSION environment variable. |
|
Hi @abhinavarora! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
No description provided.