gh-144446: Fix some frame object thread-safety issues#144479
Open
colesbury wants to merge 2 commits intopython:mainfrom
Open
gh-144446: Fix some frame object thread-safety issues#144479colesbury wants to merge 2 commits intopython:mainfrom
colesbury wants to merge 2 commits intopython:mainfrom
Conversation
Fix thread-safety issues when accessing frame attributes while another thread is executing the frame: - Add critical section to frame_repr() to prevent races when accessing the frame's code object and line number - Add _Py_NO_SANITIZE_THREAD to PyUnstable_InterpreterFrame_GetLasti() to allow intentional racy reads of instr_ptr. - Fix take_ownership() to not write to the original frame's f_executable
Contributor
Author
|
There are still some races when accessing variables through frame.f_locals, which will be address separately. |
| run_with_frame(lambda frame: repr(frame)) | ||
|
|
||
| def test_concurrent_f_trace_write(self): | ||
| """Test writing to f_trace of a live frame.""" |
Contributor
There was a problem hiding this comment.
Please use comments instead of docstrings because unittest renders docs string poorly when test fails.
| // so we need to restore it. | ||
| frame->f_executable = PyStackRef_DUP(new_frame->f_executable); | ||
| new_frame->f_executable = PyStackRef_DUP(new_frame->f_executable); | ||
| f->f_frame = new_frame; |
Contributor
There was a problem hiding this comment.
Should we move this assignment after following if?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix thread-safety issues when accessing frame attributes while another thread is executing the frame:
Add critical section to frame_repr() to prevent races when accessing the frame's code object and line number
Add _Py_NO_SANITIZE_THREAD to PyUnstable_InterpreterFrame_GetLasti() to allow intentional racy reads of instr_ptr.
Fix take_ownership() to not write to the original frame's f_executable