gh-81218: Make macOS framework builds relocatable via @rpath#144305
Open
DominiqueFuchs wants to merge 1 commit intopython:mainfrom
Open
gh-81218: Make macOS framework builds relocatable via @rpath#144305DominiqueFuchs wants to merge 1 commit intopython:mainfrom
DominiqueFuchs wants to merge 1 commit intopython:mainfrom
Conversation
DominiqueFuchs
requested review from
a team,
AA-Turner,
corona10,
emmatyping and
erlend-aasland
as code owners
|
All commit authors signed the Contributor License Agreement. |
Member
|
CC @sethmlarson, the fuzzers are failing, and it doesn't seem related. |
macOS framework builds (--enable-framework) now produce relocatable frameworks. The installed framework can be moved to any location and will work without requiring install_name_tool rewriting by users. This uses install-time transformation: build-time behavior is unchanged (absolute install names), and install_name_tool transforms the installed binaries to use @rpath. Changes: - Add -headerpad_max_install_names to LINKFORSHARED and pythonw build - Transform dylib install name to @rpath at install time - Add LC_RPATH entries to installed binaries (bin/python3, Python.app) - Compute rpath depths dynamically via os.path.relpath() Signed-off-by: Dominique Fuchs <df@0x9d.net>
DominiqueFuchs
force-pushed
the
gh-81218-relocatable-framework-rpath
branch
from
31893c4 to
3ac12f5
Compare
Author
Yeah, just rebased to current main, and they still do (indeed though, it looks totally unrelated to me and seems to happen to the other few CI runs where fuzzer runs are active and not manually skipped, too). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With these changes, macOS framework builds (--enable-framework) produce relocatable frameworks. The installed framework can be moved to any location and will work without requiring install_name_tool rewriting by users.
This uses install-time transformation: build-time behavior is unchanged (absolute install names), and install_name_tool transforms the installed binaries to use appropriate @rpath.
iOS target already uses
@rpathat build time because iOS builds are cross-compiled—there's no./python.exeexecution, no venvs, no shell script tests during development. macOS framework builds are different though and would break build-tree workflows because venv symlinks cause@executable_pathto resolve to the wrong directory, SIP stripsDYLD_FRAMEWORK_PATHfrom shell scripts, and so on.The install-time approach avoids all these issues, introducing no regression for build-tree workflows, follows existing patterns (CMake projects, Qt, ...) and makes the installed framework fully relocatable by default.
Changes
Related