Skip to content

gh-142764: Restore REPLACE_OPCODE_IF_EVALUATES_PURE optimization#143335

Merged
Fidget-Spinner merged 5 commits intopython:mainfrom
Fidget-Spinner:replace_opcodes_Fix
Jan 9, 2026
Merged

gh-142764: Restore REPLACE_OPCODE_IF_EVALUATES_PURE optimization#143335
Fidget-Spinner merged 5 commits intopython:mainfrom
Fidget-Spinner:replace_opcodes_Fix

Conversation

@Fidget-Spinner
Copy link
Member

@Fidget-Spinner Fidget-Spinner commented Jan 1, 2026

@Zheaoli
Copy link
Contributor

Zheaoli commented Jan 6, 2026

I think #143417 depends on this PR If I'm correct.

Copy link
Member

@savannahostrowski savannahostrowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think otherwise, this LGTM!

@Fidget-Spinner Fidget-Spinner merged commit 9525911 into python:main Jan 9, 2026
79 checks passed
@Fidget-Spinner Fidget-Spinner deleted the replace_opcodes_Fix branch January 9, 2026 23:18
@Fidget-Spinner
Copy link
Member Author

Thanks for the review!

reidenong pushed a commit to reidenong/cpython that referenced this pull request Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Interaction of refcount elimination and constant propagation is complex to handle

3 participants