Use canStartBuild rather than nextBuild for avoiding perf runs #584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is some evidence that a delay in nextBuild can leak to unrelated workers. Switch to canStartBuild, whose docs show an example to put the worker in “quarantine” and avoid the quarantine's exponential backoff mechanism.
encukou
changed the title
diegorusso
reviewed
Mar 18, 2025
Contributor
diegorusso
left a comment
diegorusso
left a comment
There was a problem hiding this comment.
Thanks for the change, it looks OK to me.
| builder.master.reactor.callLater( | ||
| int(delay), | ||
| deferred.callback, | ||
| requests[0], |
Contributor
There was a problem hiding this comment.
I think the problem is here, where the first element of requests is a "random" job that gets deferred.
diegorusso
approved these changes
Mar 18, 2025
zware
approved these changes
Mar 18, 2025
Member
zware
left a comment
zware
left a comment
There was a problem hiding this comment.
This looks fine to me. I do wonder if pause rather than quarantine might be a cleaner solution overall (ideally controlled by the worker itself; I have a question in to the #buildbot IRC channel about whether there's a nice way to do that), but I think this is improvement enough to go ahead with it anyway.
encukou
commented
Mar 18, 2025
Member
Author
|
AFAICS, quarantine has a built-in timeout, but to un-pause a worker we'd need to reliably schedule running some un-pausing code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is some evidence that a delay in nextBuild can leak to unrelated workers.
This switches to canStartBuild, whose docs show an example to put the worker in “quarantine” and avoid the quarantine's exponential backoff mechanism.
I'd welcome some eyes on this before testing on the live box.