Skip to content

Fix type hints of assert functions #1271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kingbuzzman merged 2 commits into from
Feb 27, 2026
Merged

Fix type hints of assert functions #1271

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ec5e70
Fix type hints of assert functions
mschoettle Feb 26, 2026
ca49b8a
Remove unused 'Collection' import
mschoettle Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions pytest_django/asserts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class MessagesTestCase(MessagesTestMixin, TestCase):
test_case = TestCase("run")

if TYPE_CHECKING:
from collections.abc import Callable, Collection, Iterator, Sequence
from collections.abc import Callable, Iterable, Iterator, Sequence
from contextlib import AbstractContextManager
from typing import Any, overload

Expand Down Expand Up @@ -130,14 +130,14 @@ def assertRaisesMessage(
expected_message: str,
*args: Any,
**kwargs: Any,
) -> None: ...
) -> Any: ...

def assertWarnsMessage(
expected_warning: Warning,
expected_message: str,
*args: Any,
**kwargs: Any,
) -> None: ...
) -> Any: ...

def assertFieldOutput(
fieldclass: type[forms.Field],
Expand All @@ -146,7 +146,7 @@ def assertFieldOutput(
field_args: Any = ...,
field_kwargs: Any = ...,
empty_value: str = ...,
) -> None: ...
) -> Any: ...

def assertHTMLEqual(
html1: str,
Expand Down Expand Up @@ -201,15 +201,15 @@ def assertXMLNotEqual(
# Removed in Django 5.1: use assertQuerySetEqual.
def assertQuerysetEqual(
qs: Iterator[Any] | list[Model] | QuerySet | RawQuerySet,
values: Collection[Any],
values: Iterable[Any],
transform: Callable[[Model], Any] | type[str] | None = ...,
ordered: bool = ...,
msg: str | None = ...,
) -> None: ...

def assertQuerySetEqual(
qs: Iterator[Any] | list[Model] | QuerySet | RawQuerySet,
values: Collection[Any],
values: Iterable[Any],
transform: Callable[[Model], Any] | type[str] | None = ...,
ordered: bool = ...,
msg: str | None = ...,
Expand Down