Revert "(CONT-801) Deprecate uriescape.rb"

[traylenator]

Summary

This reverts commit 799d608.

While uriescape was deprecated for Puppet 8 in #1307 it was already fixed earlier for Puppet 8 and ruby 3 in #1195

It is unclear to me why this function was deprecated.

Additional Context

Add any additional context about the problem here.
Function was deprecated on Puppet 8.

Related Issues (if any)

• Fixes uriescape function deprecated on P7 - no alternative on P8 #1401

Checklist

• [x ] 🟢 Spec tests.
• [x ] 🟢 Acceptance tests.
• [x ] Manually verified. (For example puppet apply)

[CLAassistant]

All committers have signed the CLA.

[traylenator]

CLA signed in agreement between CERN IT and Puppetlabs.

[ekohl]

In case that we do proceed with this: you need to update the comments on line 6 & 7.

On the question if we should proceed: I'm not sure if this is a good idea, I don't know. there's a good reason it was dropped in Ruby 3: the whole idea behind the function is sketchy. I'm more a fan of explicit URL construction where you pass the parameters unescaped and then it correctly constructs the URL.

[traylenator]

Redundant comments removed.

I only use it one place to escape PS Scavenge and PS MarkSweep before we pass them as parameters to a
puppetserver beans endpoint.

java.lang:name=PS%20Scavenge

when pulling metrics out of PuppetServer.

Does a url from component function exist ?

[ekohl]

https://docs.knapsackpro.com/2020/uri-escape-is-obsolete-percent-encoding-your-query-string suggests URI.encode_www_form_component would be the proper replacement. It only escapes a URL parameter