Rename spec files as _spec.rb so they run#1633
Open
traylenator wants to merge 1 commit intopuppetlabs:mainfrom
Open
Rename spec files as _spec.rb so they run#1633traylenator wants to merge 1 commit intopuppetlabs:mainfrom
traylenator wants to merge 1 commit intopuppetlabs:mainfrom
Conversation
A number of spec files were named incorrectly and consequently never running. Rename them so they actually run. One test now fails as a consequence. While this should be fixed one way or the other a fix for that is outside of scope of this patch.
traylenator
requested review from
a team,
SimonHoenscheid,
alexjfisher,
bastelfreak,
deric,
ekohl and
smortex
as code owners
Author
|
Easiest solution is declare the types private api and remove the tests but I'm not sure that was the original intention. |
Collaborator
|
I recall there was a rubocop-rspec plugin that looked for these wrong filenames.
@SimonHoenscheid mind taking a look since you wrote this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A batch of spec files were never being executed due to having the wrong name.
Tests have all been marked pending as I expect they have never passed.
Fixing them , deleting them or updating how the module works is best handled elsewhere as not very obvious.