You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This in necessary for distributions, like Debian, that require that C/C++ code must be compiled with certain options (like -D_FORTIFY_SOURCE=2, see the Hardening Requirements in Debian).
In the present patch, the statements for setting the variables CPPFLAGS in the Makefiles have been changed from = to +=.
Are you intentionally not touching external/flac and external/gsl ? (Or perhaps asked differently: doesn't Debian use unbundled dependencies, so why bother changing the external/ bits?)
(Or perhaps asked differently: doesn't Debian use unbundled dependencies, so why bother changing the external/ bits?)
No, Debian uses the bundled flac and gsl dependencies.
Are you intentionally not touching external/flac and external/gsl ?
Thanks for drawing my attention to this. Debian has a mechanism for injecting the hardening flags into the generated file makefile.defs (the debian/rules file does it through a snippet). Since makefile.defs is included in flac/Makefile and gsl/Makefile, there is no need for patching them. On the other hand, the patch is necessary for the other Makefiles because they do not respect previous settings of CPPFLAGS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This in necessary for distributions, like Debian, that require that C/C++ code must be compiled with certain options (like
-D_FORTIFY_SOURCE=2, see the Hardening Requirements in Debian).In the present patch, the statements for setting the variables CPPFLAGS in the Makefiles have been changed from
=to+=.