emit event after collator is rewarded #642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wizdave97
approved these changes
Jan 26, 2026
seunlanlege
approved these changes
Jan 26, 2026
Member
|
@dharjeezy let's fix an issue with collatorSelection in this PR We need a custom implementation for this https://github.com/paritytech/polkadot-sdk/blob/2da3987489a7c4bfcaddd48e99498e0759d30356/cumulus/pallets/collator-selection/src/lib.rs#L186 We should check that the stash account is mapped to a controller account and that the controller account has registered some session keys |
Member
|
The default implementation expects the stash account to register the session keys |
Member
|
Let's update the docs when we add the fix |
…egistered a controller
Wizdave97
reviewed
Jan 27, 2026
Wizdave97
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces an event after a collator is rewarded, this is most specially needed for indexing