Expand Roland S-1 MIDI CC definition to full spec

[pnilan]

Summary

• Expands the Roland S-1 synth definition from 35 to 54 CC parameters, matching the official MIDI implementation chart
• Adds 19 missing parameters: mod wheel, pan, expression, damper pedal, LFO mode, 6 chord voice controls, and 4 OSC draw/chop controls
• Documents discrete value mappings via notes fields on 17 switched parameters (e.g., polyphony mode, envelope trigger, LFO waveform, sub octave type)
• Updates tests to validate the expanded parameter count and new fields

Test plan

• All 15 existing tests pass (test_synth_yamls.py + test_synth_definitions.py)
• New test assertions verify 54-parameter count, polyphony mode notes, draw/chop section, and chord section
• Manual verification: load agent and confirm list_synths shows all 54 S-1 parameters

🤖 Generated with Claude Code

[pnilan]

I checked this against Roland's official S-1 documentation and found a few spec mismatches:

1. The YAML still uses midi_channel: 1, but Roland documents the S-1 default synth MIDI channel as 3 (and 16 for program change).
2. lfo_waveform notes are incomplete/incorrect. The manual lists six waveforms: sawtooth, inverted sawtooth, triangle, square, random, and noise. The current note string only models five buckets, so the value mapping is not reliable.
3. osc_draw_sw is not a binary off/on parameter. Roland documents three states: OFF, STEP, and SLOPE.

The CC numbers themselves look consistent with Roland's control-change list; the issues are the default channel and some of the metadata/value descriptions.

Sources:

• https://static.roland.com/assets/media/pdf/S-1_eng01_W.pdf
• https://support.roland.com/hc/en-us/articles/17188409349659-S-1-Changing-the-MIDI-channel