Skip to content

Fix synth MIDI CC configs and add Roland S-1#5

Merged
pnilan merged 1 commit intomainfrom
fix/synth-midi-configs
Mar 8, 2026
Merged

Fix synth MIDI CC configs and add Roland S-1#5
pnilan merged 1 commit intomainfrom
fix/synth-midi-configs

Conversation

@pnilan
Copy link
Owner

@pnilan pnilan commented Mar 8, 2026

What

Corrects MIDI CC mappings for Moog Minitaur and Roland TB-03, and adds a new Roland S-1 synth definition. The original Minitaur config had almost entirely wrong CC numbers. Updates tests to match.

How

  • synths/moog_minitaur.yaml: Rewrote with correct CCs sourced from midi.guide. Major corrections include filter_cutoff (22→19), filter_resonance (23→21), envelope CCs, and added ~15 new parameters (velocity sensitivity, glide types, LFO options, hard sync, release switch).
  • synths/roland_s1.yaml: New file with ~35 parameters covering oscillator, filter, envelope, LFO, performance, and effects sections.
  • synths/roland_tb03.yaml: Channel updated to 14 (local hardware config).
  • tests/test_synth_yamls.py: Updated Minitaur assertions (channel 16, filter_cutoff CC 19), TB-03 assertion (channel 14), added test_s1_yaml_loads.

Recommended Review Order

  • synths/moog_minitaur.yaml
  • synths/roland_s1.yaml
  • tests/test_synth_yamls.py
  • synths/roland_tb03.yaml

@pnilan
Fix synth MIDI CC configs and add Roland S-1 definition
794fe31 
Rewrote moog_minitaur.yaml with correct CC numbers sourced from
midi.guide (filter_cutoff=19, filter_resonance=21, etc.). Created
roland_s1.yaml with ~35 parameters. Updated test assertions to
match corrected channel numbers and CC values.
@pnilan pnilan merged commit 3c71b1a into main Mar 8, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@pnilan