-
Notifications
You must be signed in to change notification settings - Fork 709
v6.5-v8.1: update download URL from pingcap.org to pingcap.com (#22241) #22281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v6.5-v8.1: update download URL from pingcap.org to pingcap.com (#22241) #22281
Conversation
|
@Oreoxmt This PR has conflicts, I have hold it. |
|
@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Summary of ChangesHello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request systematically updates all download links within the TiDB documentation from the old 'pingcap.org' domain to the new 'pingcap.com' domain. This change ensures that users are consistently directed to the correct and up-to-date resources for downloading TiDB components, tools, and related monitoring services. Additionally, some links have been refactored to use a version placeholder for better future maintainability. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates download URLs from pingcap.org to pingcap.com across several documentation files. While most changes are correct, the automated cherry-pick process has introduced merge conflicts in multiple files. These conflicts must be resolved to ensure the documentation renders correctly. I have left comments on each file with a conflict, suggesting the likely resolution.
dm/quick-start-create-task.md
Outdated
| <<<<<<< HEAD | ||
| wget https://download.pingcap.org/tidb-community-server-v7.1.5-linux-amd64.tar.gz | ||
| ======= | ||
| wget https://download.pingcap.com/tidb-community-server-v{{{ .tidb-version }}}-linux-amd64.tar.gz | ||
| >>>>>>> e6cc410e73 (v6.5-v8.1: update download URL from pingcap.org to pingcap.com (#22241)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file contains merge conflict markers that need to be resolved. Based on the context of the pull request, the intended line is likely wget https://download.pingcap.com/tidb-community-server-v{{{ .tidb-version }}}-linux-amd64.tar.gz.
| <<<<<<< HEAD | |
| wget https://download.pingcap.org/tidb-community-server-v7.1.5-linux-amd64.tar.gz | |
| ======= | |
| wget https://download.pingcap.com/tidb-community-server-v{{{ .tidb-version }}}-linux-amd64.tar.gz | |
| >>>>>>> e6cc410e73 (v6.5-v8.1: update download URL from pingcap.org to pingcap.com (#22241)) | |
| wget https://download.pingcap.com/tidb-community-server-v{{{ .tidb-version }}}-linux-amd64.tar.gz |
pd-control.md
Outdated
| <<<<<<< HEAD | ||
| > `{version}` in the link indicates the version number of TiDB. For example, the download link for `v7.1.5` in the `amd64` architecture is `https://download.pingcap.org/tidb-community-server-v7.1.5-linux-amd64.tar.gz`. | ||
| ======= | ||
| > `{version}` in the link indicates the version number of TiDB. For example, the download link for `v{{{ .tidb-version }}}` in the `amd64` architecture is `https://download.pingcap.com/tidb-community-server-v{{{ .tidb-version }}}-linux-amd64.tar.gz`. | ||
| >>>>>>> e6cc410e73 (v6.5-v8.1: update download URL from pingcap.org to pingcap.com (#22241)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file contains merge conflict markers that need to be resolved. Based on the context of the pull request, the intended line is likely > {version} in the link indicates the version number of TiDB. For example, the download link for v{{{ .tidb-version }}} in the amd64 architecture is https://download.pingcap.com/tidb-community-server-v{{{ .tidb-version }}}-linux-amd64.tar.gz..
| <<<<<<< HEAD | |
| > `{version}` in the link indicates the version number of TiDB. For example, the download link for `v7.1.5` in the `amd64` architecture is `https://download.pingcap.org/tidb-community-server-v7.1.5-linux-amd64.tar.gz`. | |
| ======= | |
| > `{version}` in the link indicates the version number of TiDB. For example, the download link for `v{{{ .tidb-version }}}` in the `amd64` architecture is `https://download.pingcap.com/tidb-community-server-v{{{ .tidb-version }}}-linux-amd64.tar.gz`. | |
| >>>>>>> e6cc410e73 (v6.5-v8.1: update download URL from pingcap.org to pingcap.com (#22241)) | |
| > `{version}` in the link indicates the version number of TiDB. For example, the download link for `v{{{ .tidb-version }}}` in the `amd64` architecture is `https://download.pingcap.com/tidb-community-server-v{{{ .tidb-version }}}-linux-amd64.tar.gz`. |
production-deployment-using-tiup.md
Outdated
| <<<<<<< HEAD | ||
| > `{version}` in the link indicates the version number of TiDB and `{arch}` indicates the architecture of the system, which can be `amd64` or `arm64`. For example, the download link for `v7.1.0` in the `amd64` architecture is `https://download.pingcap.org/tidb-community-toolkit-v7.1.0-linux-amd64.tar.gz`. | ||
| ======= | ||
| > `{version}` in the link indicates the version number of TiDB and `{arch}` indicates the architecture of the system, which can be `amd64` or `arm64`. For example, the download link for `v7.5.0` in the `amd64` architecture is `https://download.pingcap.com/tidb-community-toolkit-v7.5.0-linux-amd64.tar.gz`. | ||
| >>>>>>> e6cc410e73 (v6.5-v8.1: update download URL from pingcap.org to pingcap.com (#22241)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file contains merge conflict markers that need to be resolved. Based on the context of the pull request, the intended line is likely > {version} in the link indicates the version number of TiDB and {arch} indicates the architecture of the system, which can be amd64 or arm64. For example, the download link for v7.5.0 in the amd64 architecture is https://download.pingcap.com/tidb-community-toolkit-v7.5.0-linux-amd64.tar.gz..
| <<<<<<< HEAD | |
| > `{version}` in the link indicates the version number of TiDB and `{arch}` indicates the architecture of the system, which can be `amd64` or `arm64`. For example, the download link for `v7.1.0` in the `amd64` architecture is `https://download.pingcap.org/tidb-community-toolkit-v7.1.0-linux-amd64.tar.gz`. | |
| ======= | |
| > `{version}` in the link indicates the version number of TiDB and `{arch}` indicates the architecture of the system, which can be `amd64` or `arm64`. For example, the download link for `v7.5.0` in the `amd64` architecture is `https://download.pingcap.com/tidb-community-toolkit-v7.5.0-linux-amd64.tar.gz`. | |
| >>>>>>> e6cc410e73 (v6.5-v8.1: update download URL from pingcap.org to pingcap.com (#22241)) | |
| > `{version}` in the link indicates the version number of TiDB and `{arch}` indicates the architecture of the system, which can be `amd64` or `arm64`. For example, the download link for `v7.5.0` in the `amd64` architecture is `https://download.pingcap.com/tidb-community-toolkit-v7.5.0-linux-amd64.tar.gz`. |
| <<<<<<< HEAD | ||
| curl -L https://download.pingcap.org/tidb-community-server-v7.1.5-linux-amd64.tar.gz | tar xzf - | ||
| ======= | ||
| curl -L https://download.pingcap.com/tidb-community-server-v{{{ .tidb-version }}}-linux-amd64.tar.gz | tar xzf - | ||
| >>>>>>> e6cc410e73 (v6.5-v8.1: update download URL from pingcap.org to pingcap.com (#22241)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file contains merge conflict markers that need to be resolved. Based on the context of the pull request, the intended line is likely curl -L https://download.pingcap.com/tidb-community-server-v{{{ .tidb-version }}}-linux-amd64.tar.gz | tar xzf -.
| <<<<<<< HEAD | |
| curl -L https://download.pingcap.org/tidb-community-server-v7.1.5-linux-amd64.tar.gz | tar xzf - | |
| ======= | |
| curl -L https://download.pingcap.com/tidb-community-server-v{{{ .tidb-version }}}-linux-amd64.tar.gz | tar xzf - | |
| >>>>>>> e6cc410e73 (v6.5-v8.1: update download URL from pingcap.org to pingcap.com (#22241)) | |
| curl -L https://download.pingcap.com/tidb-community-server-v{{{ .tidb-version }}}-linux-amd64.tar.gz | tar xzf - |
upgrade-monitoring-services.md
Outdated
| <<<<<<< HEAD | ||
| > `{version}` in the link indicates the version number of TiDB and `{arch}` indicates the architecture of the system, which can be `amd64` or `arm64`. For example, the download link for `v7.1.0` in the `amd64` architecture is `https://download.pingcap.org/tidb-community-toolkit-v7.1.0-linux-amd64.tar.gz`. | ||
| ======= | ||
| > `{version}` in the link indicates the version number of TiDB and `{arch}` indicates the architecture of the system, which can be `amd64` or `arm64`. For example, the download link for `v{{{ .tidb-version }}}` in the `amd64` architecture is `https://download.pingcap.com/tidb-community-toolkit-v{{{ .tidb-version }}}-linux-amd64.tar.gz`. | ||
| >>>>>>> e6cc410e73 (v6.5-v8.1: update download URL from pingcap.org to pingcap.com (#22241)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file contains merge conflict markers that need to be resolved. Based on the context of the pull request, the intended line is likely > {version} in the link indicates the version number of TiDB and {arch} indicates the architecture of the system, which can be amd64 or arm64. For example, the download link for v{{{ .tidb-version }}} in the amd64 architecture is https://download.pingcap.com/tidb-community-toolkit-v{{{ .tidb-version }}}-linux-amd64.tar.gz..
| <<<<<<< HEAD | |
| > `{version}` in the link indicates the version number of TiDB and `{arch}` indicates the architecture of the system, which can be `amd64` or `arm64`. For example, the download link for `v7.1.0` in the `amd64` architecture is `https://download.pingcap.org/tidb-community-toolkit-v7.1.0-linux-amd64.tar.gz`. | |
| ======= | |
| > `{version}` in the link indicates the version number of TiDB and `{arch}` indicates the architecture of the system, which can be `amd64` or `arm64`. For example, the download link for `v{{{ .tidb-version }}}` in the `amd64` architecture is `https://download.pingcap.com/tidb-community-toolkit-v{{{ .tidb-version }}}-linux-amd64.tar.gz`. | |
| >>>>>>> e6cc410e73 (v6.5-v8.1: update download URL from pingcap.org to pingcap.com (#22241)) | |
| > `{version}` in the link indicates the version number of TiDB and `{arch}` indicates the architecture of the system, which can be `amd64` or `arm64`. For example, the download link for `v{{{ .tidb-version }}}` in the `amd64` architecture is `https://download.pingcap.com/tidb-community-toolkit-v{{{ .tidb-version }}}-linux-amd64.tar.gz`. |
upgrade-monitoring-services.md
Outdated
| <<<<<<< HEAD | ||
| > `{version}` in the link indicates the version number of TiDB and `{arch}` indicates the architecture of the system, which can be `amd64` or `arm64`. For example, the download link for `v7.1.0` in the `amd64` architecture is `https://download.pingcap.org/tidb-community-toolkit-v7.1.0-linux-amd64.tar.gz`. | ||
| ======= | ||
| > `{version}` in the link indicates the version number of TiDB and `{arch}` indicates the architecture of the system, which can be `amd64` or `arm64`. For example, the download link for `v{{{ .tidb-version }}}` in the `amd64` architecture is `https://download.pingcap.com/tidb-community-toolkit-v{{{ .tidb-version }}}-linux-amd64.tar.gz`. | ||
| >>>>>>> e6cc410e73 (v6.5-v8.1: update download URL from pingcap.org to pingcap.com (#22241)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file contains merge conflict markers that need to be resolved. Based on the context of the pull request, the intended line is likely > {version} in the link indicates the version number of TiDB and {arch} indicates the architecture of the system, which can be amd64 or arm64. For example, the download link for v{{{ .tidb-version }}} in the amd64 architecture is https://download.pingcap.com/tidb-community-toolkit-v{{{ .tidb-version }}}-linux-amd64.tar.gz..
| <<<<<<< HEAD | |
| > `{version}` in the link indicates the version number of TiDB and `{arch}` indicates the architecture of the system, which can be `amd64` or `arm64`. For example, the download link for `v7.1.0` in the `amd64` architecture is `https://download.pingcap.org/tidb-community-toolkit-v7.1.0-linux-amd64.tar.gz`. | |
| ======= | |
| > `{version}` in the link indicates the version number of TiDB and `{arch}` indicates the architecture of the system, which can be `amd64` or `arm64`. For example, the download link for `v{{{ .tidb-version }}}` in the `amd64` architecture is `https://download.pingcap.com/tidb-community-toolkit-v{{{ .tidb-version }}}-linux-amd64.tar.gz`. | |
| >>>>>>> e6cc410e73 (v6.5-v8.1: update download URL from pingcap.org to pingcap.com (#22241)) | |
| > `{version}` in the link indicates the version number of TiDB and `{arch}` indicates the architecture of the system, which can be `amd64` or `arm64`. For example, the download link for `v{{{ .tidb-version }}}` in the `amd64` architecture is `https://download.pingcap.com/tidb-community-toolkit-v{{{ .tidb-version }}}-linux-amd64.tar.gz`. |
c7fbbc0 to
80c6661
Compare
|
/approve |
|
/unhols |
|
/unhold |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Oreoxmt The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #22241
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?