Introduce DefaultValuesStrategy for constructor & property defaults#601
Merged
veewee merged 1 commit intophpro:v5.xfrom Feb 27, 2026
Merged
Conversation
veewee
force-pushed
the
consistent-default-values-code-generator
branch
2 times, most recently
from
0e30e80 to
d39f2a5
Compare
veewee
changed the title
…vider
- Add ScalarDefaultProvider that determines type-appropriate defaults
for properties (string='', int=0, bool=false, float=0.0, array=[],
nullable=null)
- Add withDefaultValues() option to PropertyAssembler (enabled by default),
replacing the separate PropertyDefaultsAssembler
- Add withDefaultValues() option to ConstructorAssembler (enabled by default),
with automatic reordering of parameters so those with defaults come last
- Add withOptionalValue() option to ConstructorAssembler, forcing all
parameters to ?Type = null (matching PropertyAssembler behavior)
- Remove PropertyDefaultsAssembler (functionality folded into PropertyAssembler)
veewee
force-pushed
the
consistent-default-values-code-generator
branch
from
d39f2a5 to
0a635f9
Compare
veewee
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ScalarDefaultProviderthat determines type-appropriate defaults for properties ('',0,false,0.0,[],null)DefaultValuesStrategyenum (None,OptionalOnly,All) to control default value behaviorwithDefaultValues()option to bothConstructorAssemblerandPropertyAssembler, replacing the separatePropertyDefaultsAssemblerwithOptionalValue()option toConstructorAssembler, forcing all parameters to?Type = nullPropertyDefaultsAssembler(functionality folded intoPropertyAssembler)Default behavior
The default strategy is
OptionalOnly: only WSDL-optional/nullable properties receive= null. This prevents required properties from silently getting defaults like= ''or= 0, which would allow constructing objects without providing them.Users can opt into the previous "all scalars get defaults" behavior with
DefaultValuesStrategy::All, or disable defaults entirely withDefaultValuesStrategy::None.