Skip to content

Strip suffix when comparing versions #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
asgrim merged 1 commit into from
Jan 26, 2026
Merged

Strip suffix when comparing versions #487

asgrim merged 1 commit into from
Jan 26, 2026

Conversation

@mbeccati
Copy link
Contributor

@mbeccati mbeccati commented Jan 21, 2026 

1) Php\PieUnitTest\Platform\TargetPhp\PhpBinaryPathTest::testVersionFromCurrentProcess
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'8.5.3-dev'
+'8.5.3'

:-)

asgrim
asgrim reviewed Jan 21, 2026
View reviewed changes
@mbeccati mbeccati force-pushed the fix-php-version-check branch from 1797e51 to 4a95fae Compare January 21, 2026 09:29
@mbeccati mbeccati force-pushed the fix-php-version-check branch from 4a95fae to 7df9e3e Compare January 21, 2026 09:34
@asgrim asgrim self-requested a review January 26, 2026 10:44
@asgrim asgrim added the enhancement New feature or request label Jan 26, 2026
@asgrim asgrim self-assigned this Jan 26, 2026
@asgrim asgrim added this to the 1.3.7 milestone Jan 26, 2026
@asgrim asgrim merged commit a8bf21c into php:1.3.x Jan 26, 2026
22 checks passed
@mbeccati mbeccati deleted the fix-php-version-check branch January 26, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asgrim asgrim Awaiting requested review from asgrim

Assignees

@asgrim asgrim

Labels

enhancement New feature or request

Projects

None yet

Milestone

1.3.7

Development

Successfully merging this pull request may close these issues.

2 participants

@mbeccati @asgrim