GH-20783: support \f in trim, rtrim and ltrim
#20788
Draft
+9
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I searched keyword
trimin the codebase and fix every case I think related to the three functions. I didn't touch other features with trim implemented and missing\f. (such astrimin php filters or other code)This PR changes:
charactersoftrim(alsoltrimandrtrim) in the php interface, adding\f, sourcephp_trim_int(which effectsphp_trim), source\f.I am sending mails to internals now. After that I will write the NEWS file (and docs) if this feature is accepted.
doc of trim: https://www.php.net/manual/en/function.trim.php
This is my first time contributing to php so I am not so sure about this PR. Thanks.
ps: also a little detail. I change the default parameter to
\f\n\t\r\v\0using alphabetic orders. (abcdefghijklmn...)