Fix for Gym environment framework changes#17
Open
marginloop wants to merge 2 commits intophiltabor:masterfrom
Open
Fix for Gym environment framework changes#17marginloop wants to merge 2 commits intophiltabor:masterfrom
marginloop wants to merge 2 commits intophiltabor:masterfrom
Conversation
from Gym API "Accepts an action and returns a tuple (observation, reward, terminated, truncated, info)"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
env.reset() returns an observation and info. This fixes issues with the expected size of a tuple.
from gym library api https://www.gymlibrary.dev/api/core/#gym.Env.reset
env.step returns a tuple with an additional variable. adding a throwaway variable fixes errors with expected return lengths.
from gym library api https://www.gymlibrary.dev/api/core/#gym.Env.step