[FEATURE] Added timezone selection to dashboard #43

christophrichtersap · 2026-01-21T09:53:44Z

Description

Added timezone selector to customize data view

Fixes: #2843

Screenshots

timezone_selector.mov

Checklist

Pull request has a descriptive title and context useful to a reviewer.
Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
All commits have DCO signoffs.

UI Changes

Changes that impact the UI include screenshots and/or screencasts of the relevant changes.
Code follows the UI guidelines.
E2E tests are stable and unlikely to be flaky.
See e2e docs for more details. Common issues include:
- Is the data inconsistent? You need to mock API requests.
- Does the time change? You need to use consistent time values or mock time utilities.
- Does it have loading states? You need to wait for loading to complete.

Signed-off-by: christophrichtersap <christoph.richter@sap.com>

jgbernalp · 2026-01-21T10:21:09Z

@christophrichtersap the video seems very low res, so I'm not sure if I missed the detail. But do we show the current selected timezone?

christophrichtersap · 2026-01-21T10:24:20Z

@christophrichtersap the video seems very low res, so I'm not sure if I missed the detail. But do we show the current selected timezone?

Hi,

showing up on hoover above icon. In case some other visualisation is preferred drop a line.

jgbernalp · 2026-01-21T10:37:43Z

I think it will be better inline, aligned to the right of the header title. Tooltips are easily ignored.

christophrichtersap · 2026-01-21T11:08:54Z

I think it will be better inline, aligned to the right of the header title. Tooltips are easily ignored.

You prefer this version?

jgbernalp · 2026-01-21T12:25:31Z

It seems it takes too much horizontal, space. If you don't mind, can we add it in the footer of this menu? That way still visible, it does not consume more horizontal space and can be changed easily.

christophrichtersap · 2026-01-21T12:44:06Z

jgbernalp · 2026-01-21T14:21:31Z

yes that LGTM

Signed-off-by: christophrichtersap <christoph.richter@sap.com>

Gladorme · 2026-01-21T15:08:43Z

components/src/TimeRangeSelector/DateTimeRangePicker.tsx

  const [showStartCalendar, setShowStartCalendar] = useState<boolean>(true);

+  // Reformat inputs when timezone changes so UI reflects current selection
+  useEffect(() => {


Misusage of useEffect. I think the best would to have a useMemo formatting timeRange and keep timeRange unformatted in useState?

Commit removed useState using useMemo for dateTimeRange

plugin-system/src/components/TimeRangeControls/TimeRangeControls.tsx

plugin-system/src/model/log-queries.ts

components/src/model/timeZoneOption.ts

components/src/TimeRangeSelector/TimeRangeSelector.tsx

added default js timezone with search capabilites replaced display _ to ' ' in DateZoneFormat Signed-off-by: christophrichtersap <christoph.richter@sap.com>

Signed-off-by: christophrichtersap <christoph.richter@sap.com>

plugin-system/src/components/TimeRangeControls/TimeRangeControls.tsx

components/src/TimeRangeSelector/DateTimeRangePicker.tsx

components/src/TimeRangeSelector/TimeRangeSelector.tsx

… query refresh on tz change just apply visualisation Signed-off-by: christophrichtersap <christoph.richter@sap.com>

Gladorme

LGTM, thanks!

christophrichtersap requested a review from a team as a code owner January 21, 2026 09:53

christophrichtersap added 2 commits January 21, 2026 10:54

added timezone selection on dashboard level

fd57209

Signed-off-by: christophrichtersap <christoph.richter@sap.com>

fixed lint and test issues

dff0d57

Signed-off-by: christophrichtersap <christoph.richter@sap.com>

christophrichtersap force-pushed the timezone branch from 5183103 to dff0d57 Compare January 21, 2026 09:54

christophrichtersap added 2 commits January 21, 2026 15:35

added footer timezone information

6c6abbc

Signed-off-by: christophrichtersap <christoph.richter@sap.com>

fixed lint and test issues

d574310

Signed-off-by: christophrichtersap <christoph.richter@sap.com>

Gladorme reviewed Jan 21, 2026

View reviewed changes

plugin-system/src/components/TimeRangeControls/TimeRangeControls.tsx Outdated Show resolved Hide resolved

Gladorme reviewed Jan 21, 2026

View reviewed changes

plugin-system/src/model/log-queries.ts Outdated Show resolved Hide resolved

Nexucis reviewed Jan 21, 2026

View reviewed changes

components/src/model/timeZoneOption.ts Outdated Show resolved Hide resolved

Gladorme reviewed Jan 21, 2026

View reviewed changes

components/src/model/timeZoneOption.ts Outdated Show resolved Hide resolved

Gladorme reviewed Jan 21, 2026

View reviewed changes

components/src/TimeRangeSelector/TimeRangeSelector.tsx Show resolved Hide resolved

christophrichtersap added 4 commits January 22, 2026 08:48

Adjustment due to review

0913661

added default js timezone with search capabilites replaced display _ to ' ' in DateZoneFormat Signed-off-by: christophrichtersap <christoph.richter@sap.com>

added timezone to mandatory field in parent

2c691c7

Signed-off-by: christophrichtersap <christoph.richter@sap.com>

removed useState using useMemo for dateTimeRange

a9167a8

Signed-off-by: christophrichtersap <christoph.richter@sap.com>

fixed lint and test issues

7eb6324

Signed-off-by: christophrichtersap <christoph.richter@sap.com>

christophrichtersap force-pushed the timezone branch from 76af14d to 7eb6324 Compare January 22, 2026 08:33

christophrichtersap requested a review from Gladorme January 22, 2026 08:41

Gladorme reviewed Jan 22, 2026

View reviewed changes

plugin-system/src/components/TimeRangeControls/TimeRangeControls.tsx Outdated Show resolved Hide resolved

Gladorme reviewed Jan 22, 2026

View reviewed changes

components/src/TimeRangeSelector/DateTimeRangePicker.tsx Outdated Show resolved Hide resolved

Gladorme reviewed Jan 22, 2026

View reviewed changes

components/src/TimeRangeSelector/TimeRangeSelector.tsx Outdated Show resolved Hide resolved

removed useMemo on cheap calculations, as remove complexity + removed…

3d7ff0f

… query refresh on tz change just apply visualisation Signed-off-by: christophrichtersap <christoph.richter@sap.com>

christophrichtersap requested a review from Gladorme January 22, 2026 14:49

Merge branch 'main' into timezone

525e0b6

Gladorme approved these changes Jan 23, 2026

View reviewed changes

[FEATURE] Added timezone selection to dashboard #43

Are you sure you want to change the base?

[FEATURE] Added timezone selection to dashboard #43

Uh oh!

Conversation

christophrichtersap commented Jan 21, 2026

Description

Screenshots

Checklist

UI Changes

Uh oh!

jgbernalp commented Jan 21, 2026

Uh oh!

christophrichtersap commented Jan 21, 2026

Uh oh!

jgbernalp commented Jan 21, 2026

Uh oh!

christophrichtersap commented Jan 21, 2026

Uh oh!

jgbernalp commented Jan 21, 2026

Uh oh!

christophrichtersap commented Jan 21, 2026

Uh oh!

jgbernalp commented Jan 21, 2026

Uh oh!

Gladorme Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

christophrichtersap Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Gladorme left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants