Fix Stream spec format string for P4 versions prior 2020.2#13
Open
microdee wants to merge 1 commit intoperforce:masterfrom
Open
Fix Stream spec format string for P4 versions prior 2020.2#13microdee wants to merge 1 commit intoperforce:masterfrom
microdee wants to merge 1 commit intoperforce:masterfrom
Conversation
…ntained `Components` field, this caused a runtime error manifested in a format-parameter-argument-count mismatch.
MartiPixaera
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spec format string for P4 versions prior 2020.2 shouldn't have contained
Componentsfield, this caused a runtime error manifested in a format-parameter-argument-count mismatch, when ParentView was None.Suggestion outside the scope of this PR
To avoid such errors in the future, it is safer to use interpolated raw-string-literals introduced in C# 11:
Or if C# 11 is not feasible for this codebase then C# 6 interpolated string literals are also better for this purpose.