fix(print): guard division-by-zero & correct wcorder args#3
Open
isaeedam-ir wants to merge 1 commit intopeprodev:masterfrom
Open
fix(print): guard division-by-zero & correct wcorder args#3isaeedam-ir wants to merge 1 commit intopeprodev:masterfrom
isaeedam-ir wants to merge 1 commit intopeprodev:masterfrom
Conversation
isaeedam-ir
commented
Oct 13, 2025
isaeedam-ir
commented
- Fixes fatal DivisionByZeroError when $realprice is 0 (email invoice PDF generation).
- Adds guard for $wasPrice <= 0, clamps result to 0..100.
- Corrects wcorder call to calc_precentage(new=total, was=subtotal).
- Repro: mark multiple orders “processing” with subtotal=0 (or total=0), plugin attaches PDF → fatal.
- Env: WP 6.8.3, WooCommerce (version), PHP 8.4.x.
…rder args Fixes fatal DivisionByZeroError when $realprice is 0 (email invoice PDF generation). Adds guard for $wasPrice <= 0, clamps result to 0..100. Corrects wcorder call to calc_precentage(new=total, was=subtotal). Repro: mark multiple orders “processing” with subtotal=0 (or total=0), plugin attaches PDF → fatal. Env: WP 6.8.3, WooCommerce (version), PHP 8.4.x.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.